feat(QTDI-693): manage nested jars#969
Merged
ypiel-talend merged 25 commits intomasterfrom Aug 20, 2025
Merged
Conversation
container/container-core/src/main/java/org/talend/sdk/component/container/ContainerManager.java
Show resolved
Hide resolved
...runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java
Show resolved
Hide resolved
Contributor
ozhelezniak-talend
left a comment
ozhelezniak-talend
left a comment
There was a problem hiding this comment.
left comments
ozhelezniak-talend
previously approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Pull Request Overview
This pull request implements support for managing nested JARs in the Talend SDK component runtime. The changes enable the system to detect and handle components that are packaged within fat JARs with embedded Maven repositories.
- Adds nested repository detection logic to check for
MAVEN-INF/repositoryresources when default repository paths are used - Extends classloader functionality to track and expose nested JAR URLs
- Updates component scanning to handle nested repositories with proper filtering
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ContainerManager.java | Implements nested repository detection and fallback logic for fat JAR scenarios |
| Container.java | Adds public accessor method for nested repository status |
| ConfigurableClassLoader.java | Tracks nested URLs and overrides getURLs() to include them |
| ComponentManagerTest.java | Updates test expectations to account for nested JAR handling |
| ComponentManager.java | Enhances component scanning to handle nested repositories with proper filtering |
Comments suppressed due to low confidence (1)
component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java:1328
- [nitpick] The log message format with manual bracket prefix is inconsistent with typical logging patterns. Consider using standard log formatting without manual prefixes.
log.info("[onCreate] Can't read nested scanning.properties: {}", e.getMessage());
container/container-core/src/main/java/org/talend/sdk/component/container/ContainerManager.java
Show resolved
Hide resolved
container/container-core/src/main/java/org/talend/sdk/component/container/ContainerManager.java
Show resolved
Hide resolved
| @Getter | ||
| private final List<String> cacheableClasses; | ||
|
|
||
| private List<URL> nestedURLs = new ArrayList<>(); |
There was a problem hiding this comment.
The field should be declared as final since it's initialized once and never reassigned. Consider making it final for better immutability.
Suggested change
| private List<URL> nestedURLs = new ArrayList<>(); | |
| private final List<URL> nestedURLs = new ArrayList<>(); |
* add snapshot plugin oss repo * remove talend-icon * remove org.talend.ui:talend-icon:3.8.0 it's deprecated dependency, and its content is already inside the folder of documentation/src/main/antora/modules/ROOT/assets/images/icons/svg
* feat(QTDI-113): Support Java 17 compilation (#936) --------- Co-authored-by: Emmanuel GALLOIS <emmanuel.gallois@qlik.com> Co-authored-by: undx <ouf@qlik.com> Co-authored-by: Axel CATOIRE <axel.catoire@qlik.com>
* it was removed in 2020 and looks like we've missed it, it was added in a lot of modules for Cloud, but I think by mistake it was removed from component-runtime-manager.
* nexus creds for deps report * use settings.xml for deps report
- fix springboot repackaging to BOOT-INF/ issue
- fix springboot repackaging to BOOT-INF/ issue
ozhelezniak-talend
approved these changes
Aug 8, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://qlik-dev.atlassian.net/browse/QTDI-693
component-runtime:
master:
maintenance/8.0.2 (used for building test studio) :